Attention is currently required from: Angel Pons, Felix Held, Martin L Roth, Ravi Mistry.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62200?usp=email )
Change subject: superio/fintek/f71808a: Add VT2 boundary registers
......................................................................
Patch Set 5:
(2 comments)
File src/superio/fintek/f71808a/f71808a_hwm.c:
https://review.coreboot.org/c/coreboot/+/62200/comment/8c0c6748_b339464a :
PS5, Line 22: /* May be for fans 1 and 2 - rename? */
Let's not document todos in code. Please remove, and open a ticket or submit a separate patch.
https://review.coreboot.org/c/coreboot/+/62200/comment/8f8d2115_b752bcc7 :
PS5, Line 36: #define HWM_VT2_BOUNDARY_1_TEMPERATURE 0xb6
: #define HWM_VT2_BOUNDARY_2_TEMPERATURE 0xb7
: #define HWM_VT2_BOUNDARY_3_TEMPERATURE 0xb8
: #define HWM_VT2_BOUNDARY_4_TEMPERATURE 0xb9
:
Move them below VT1 registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62200?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f6b50da073cb55e141d6bf5185433c21d3fb554
Gerrit-Change-Number: 62200
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi Mistry
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Ravi Mistry
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Ravi Mistry
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 06 Jan 2024 21:46:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
