Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47572 )
Change subject: nb/intel/sandybridge: Use bitfield for GDCRTRAININGMOD register ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47572/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.h:
https://review.coreboot.org/c/coreboot/+/47572/2/src/northbridge/intel/sandy... PS2, Line 134: 4
you doofus
Done
https://review.coreboot.org/c/coreboot/+/47572/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/47572/2/src/northbridge/intel/sandy... PS2, Line 2510: .vref_gen_ctl = reg3000b24[i],
This seems to not work well anymore...
Done