[coreboot-gerrit] [M] Change in coreboot[main]: arch/riscv: add new SBI calls

[ron minnich (Code Review)]

Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune, Philipp Hug.

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81294?usp=email )

Change subject: arch/riscv: add new SBI calls
......................................................................

Patch Set 10:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81294/comment/0a20aecc_db2ddc42 :
PS9, Line 15: clang-formatted-by: Ronald G Minnich
> This is odd. Is it needed? […]

That was put in by some turd I added to the makefile long ago, which I have a CL up to remove. Sorry, will remove it.

File src/arch/riscv/sbi.c:

https://review.coreboot.org/c/coreboot/+/81294/comment/2edae5f5_f4212399 :
PS9, Line 97: __weak
> I kind of hate this. Weak functions are bad enough, but weak arrays? Yuck. […]

I got rid of the weak, we can likely solve this some other way.

https://review.coreboot.org/c/coreboot/+/81294/comment/1f9d1603_d629b348 :
PS9, Line 120: if (0)
> maybe `if (SBI_DEBUG)` and put that #define at the top of the file?

I nuked the code, it's cleaner :-)