Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46393 )
Change subject: soc/mediatek/mt8192: Add dpm loader
......................................................................
Patch Set 33:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46393/33/src/soc/mediatek/mt8192/dp...
File src/soc/mediatek/mt8192/dpm.c:
https://review.coreboot.org/c/coreboot/+/46393/33/src/soc/mediatek/mt8192/dp...
PS33, Line 18: if (load_blob_file(dm_file_name, DPM_DM_SRAM_BASE))
if errors, load_blob_file function should print errors, is it?
load_blob_file will print error message if failed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16b341ad63940b45b886c4a7fd733c1970624e40
Gerrit-Change-Number: 46393
Gerrit-PatchSet: 33
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Dec 2020 06:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-MessageType: comment