Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37392 )
Change subject: cpu/x86/smm/smm_stub: Add x86_64 support ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37392/7/src/cpu/x86/smm/smm_stub.S File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/37392/7/src/cpu/x86/smm/smm_stub.S@... PS7, Line 190: #include <cpu/x86/64bit/entry64.inc> Maybe some idea's for moving the page tables into SMM (for follow up patches): - Because the stub is used for both relocating SMM as the actual SMM handler, add the page table offset to 'module_parameters' * On the relocation stub: Just use CONFIG_ARCH_X86_64_PGTBL_LOC * On the permanent handler: Add a region in smm_load_module() (see chart above that function definition) and copy the CONFIG_ARCH_X86_64_PGTBL_LOC there and have the permanent handler relocatable module parameter to point to that. - Turn setup_longmode into a macro with the page table location at %eax to allow other than CONFIG_ARCH_X86_64_PGTBL_LOC pagetables.
If you want I can have a go at implementing that?