Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44974 )
Change subject: soc/intel/xeon_sp/cpx: display FSP_PREV_BOOT_ERR_SRC_HOB ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44974/3/src/soc/intel/xeon_sp/cpx/h... File src/soc/intel/xeon_sp/cpx/hob_display.c:
https://review.coreboot.org/c/coreboot/+/44974/3/src/soc/intel/xeon_sp/cpx/h... PS3, Line 192: type = (uint8_t *)((void *)hob + len); There's no need for `type` to be a pointer:
const uint8_t type = *(uint8_t *)((void *)hob + len);
Ideally, we should try to avoid doing pointer arithmetic, but without changing the FSP headers it's just not feasible. If I could decide, I'd use a union so that all entries have the same size.