John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39261 )
Change subject: soc/intel/tigerlake: Avoid NULL pointer dereference
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39261/2/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39261/2/src/soc/intel/tigerlake/rom...
PS2, Line 98: dev
What is this supposed to be? The IGD?
Thanks for pointing the mistake. dev should be HDA instead of IGD.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a62da44c7044f9dc281eae0949f7f7b612ab238
Gerrit-Change-Number: 39261
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 03 Mar 2020 21:55:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment