Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36001 )
Change subject: vendorcode/amd/agesa/f16kb/Proc/Fch/Sata/Family/Yangtze: Remove redundant FIS code ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36001/2/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/Fch/Sata/Family/Yangtze/YangtzeSataService.c:
https://review.coreboot.org/c/coreboot/+/36001/2/src/vendorcode/amd/agesa/f1... PS2, Line 370: // FchSataFisBasedSwitching If I'd read the comment without seeing this commit, I'd think that the line below is because that flag is always set. From this change it seems that you always took the "else" path. Could you make the intent of the comment clearer here?