Attention is currently required from: Felix Singer, Andy Pont, Paul Menzel.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59705 )
Change subject: mainboard/starlabs/labtop: Hook up Thunderbolt to CMOS
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/starlabs/labtop/variants/tgl/devtree.c:
https://review.coreboot.org/c/coreboot/+/59705/comment/81661a80_c55812af
PS8, Line 58: if (get_uint_option("thunderbolt", 1) == 0) {
It will be more efficient just to call get_uint_option() once and store the return value in a variab […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibadc7464831242ae51982610b410ccf0a6811edd
Gerrit-Change-Number: 59705
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 09 Dec 2021 14:41:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andy Pont
andy.pont@sdcsystems.com
Gerrit-MessageType: comment