Attention is currently required from: Andrey Petrov, Angel Pons, Michał Żygowski, Sean Rhodes.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65680?usp=email )
Change subject: soc/intel/apollolake: Create IBB, IBBL and OBB
......................................................................
Patch Set 27:
(1 comment)
File src/soc/intel/apollolake/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/65680/comment/10aa0232_2617151a :
PS27, Line 212: dd if=$(objcbfs)/$(call strip_quotes,$(CONFIG_IBBM_ROM_COMPONENT)) \
: of=$@ skip=96 bs=1 count=$(call _toint,$(CONFIG_IBBM_ROM_SIZE))
Is this some sort hacky skipping of the ELF header? I suggest using objcopy to create a binary that you can use.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65680?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0deebf04f22f3017ee0c13bf1ca7f6dcc0d458b5
Gerrit-Change-Number: 65680
Gerrit-PatchSet: 27
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 21 Mar 2024 19:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment