Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36130 )
Change subject: soc/intel/broadwell: Fix 'dead increment' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36130/1/src/soc/intel/broadwell/sat... File src/soc/intel/broadwell/sata.c:
https://review.coreboot.org/c/coreboot/+/36130/1/src/soc/intel/broadwell/sat... PS1, Line 78: reg16 = 0; /* Disable alternate ID */ : reg16 = 1 << 5; /* BWG step 12 */ I suppose what scan-build is really complaining about is that the variable is first set to 0, then to another value before that 0 was ever used. You could just make these two lines into "reg = 1 << 5;", no?