Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46033 )
Change subject: drivers/wifi: Drop maxsleep parameter from chip config
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/intel/wifi/wifi...
File src/drivers/intel/wifi/wifi.c:
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/intel/wifi/wifi...
PS1, Line 54: By default, all intel wifi chips wake from S3
If you are looking at the PM1_CNT register, then 4 is not a valid value.
Yeah, however, Intel datasheets tend to be very wrong sometimes
Also, do you know if the mainboard is designed to support wake from wifi(cnvi) in S5?
I'm not sure about the requirements
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42131fced008da0d51f0f777b7f2d99deaf68827
Gerrit-Change-Number: 46033
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 21:08:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment