Attention is currently required from: Jakub Czapiga, Paul Fagerburg, Julius Werner, Jan Dabros. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58327 )
Change subject: libpayload/tests: Add libcbfs/cbfs_core-test test case ......................................................................
Patch Set 2:
(6 comments)
Patchset:
PS2: Partial review for get_cbfs_header().
File payloads/libpayload/tests/libcbfs/cbfs_core-test.c:
https://review.coreboot.org/c/coreboot/+/58327/comment/fdd1bb60_850e6f39 PS2, Line 208: htobe32 We're using ntohl() in the code, so htonl() would be more consistent here (although they are the same thing 😊).
https://review.coreboot.org/c/coreboot/+/58327/comment/43005107_d5dd419e PS2, Line 209: 0xFFFFFFFF Use UINT32_MAX?
https://review.coreboot.org/c/coreboot/+/58327/comment/dcfafda7_79298cd3 PS2, Line 332: It took me a while to understand how cbfs_get_handle_test_state is initialized. How about adding a short comment explaining that?
/* Convert cbfs_get_handle_test_prestate to cbfs_get_handle_test_state. */
https://review.coreboot.org/c/coreboot/+/58327/comment/2e168e69_5b1bd0e3 PS2, Line 367: LP_ARCH_X86 Should we return error instead of silently ignoring use_aligned_bootblocksize for non-x86 platforms?
https://review.coreboot.org/c/coreboot/+/58327/comment/8d24d833_bb7e1163 PS2, Line 966: NULL This is the same as CBFS_DEFAULT_MEDIA, so the line
test_media = &local_media
will never run.