Attention is currently required from: Tarun Tuli, Subrata Banik.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74405 )
Change subject: soc/intel/tigerlake: Replace SOC_INTEL_TIGERLAKE_S3 with D3COLD_SUPPORT
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74405/comment/1b1416a3_e555354b
PS5, Line 7: Remove the SOC_INTEL_TIGERLAKE_S3 symbol
Maybe "Replace SOC_INTEL_TIGERLAKE_S3 with D3COLD_SUPPORT" or "Transition from SOC_INTEL_TIGERLAKE_S […]
Only the former is short enough
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id43f3e5c8620d474831cc02fcecebd8aac961687
Gerrit-Change-Number: 74405
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 17 Apr 2023 19:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment