Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67995 )
Change subject: mb/google/skyrim: move EC switch selection from ChromeOS to Vboot ......................................................................
mb/google/skyrim: move EC switch selection from ChromeOS to Vboot
This is a vboot feature, not a ChromeOS one, and unless selected by vboot, compilation will fail in the non-ChromeOS + vboot build case.
TEST=build/boot skyrim w/vboot, w/o ChromeOS
Change-Id: If9a5343907457bf3319f045262fdddf7eae2f1cb Signed-off-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/67995 Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/skyrim/Kconfig 1 file changed, 19 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index fc54f64..cf2e136 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -44,9 +44,6 @@ select PCIEXP_COMMON_CLOCK select PCIEXP_L1_SUB_STATE
-config CHROMEOS - select EC_GOOGLE_CHROMEEC_SWITCHES - config DEVICETREE default "variants/baseboard/devicetree.cb"
@@ -84,6 +81,7 @@ default "morthal" if BOARD_GOOGLE_MORTHAL
config VBOOT + select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH select VBOOT_SEPARATE_VERSTAGE