Ting Shen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31122 )
Change subject: selfload: check target memory type in selfload_check ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/#/c/31122/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31122/4//COMMIT_MSG@11 PS4, Line 11:
Why is that needed? Please add the motivation to the commit message.
Done
https://review.coreboot.org/#/c/31122/4/src/arch/arm64/arm_tf.c File src/arch/arm64/arm_tf.c:
https://review.coreboot.org/#/c/31122/4/src/arch/arm64/arm_tf.c@53 PS4, Line 53: BM_MEM_RESERVED
Yes, new bootmem type will be in another CL.
reverted this line to prevent things broken before next CL landed.
https://review.coreboot.org/#/c/31122/4/src/include/bootmem.h File src/include/bootmem.h:
https://review.coreboot.org/#/c/31122/4/src/include/bootmem.h@100 PS4, Line 100: bootmem_region_targets_ram
Should probably rename this to bootmem_region_targets_type()
Done
https://review.coreboot.org/#/c/31122/4/src/lib/selfboot.c File src/lib/selfboot.c:
https://review.coreboot.org/#/c/31122/4/src/lib/selfboot.c@49 PS4, Line 49: segment_targets_usable_ram
Should also be renamed (e.g. segment_targets_type()).
Done
https://review.coreboot.org/#/c/31122/4/src/lib/selfboot.c@251 PS4, Line 251: enum bootmem_type dest_type
If you want to treat the checker_t argument as a void*, you should do that here already (or don't do […]
Done