Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31706 )
Change subject: cbfstool: Change FMD annotation to flags
......................................................................
Patch Set 5:
Do both, convert the tool documentation and refactor it. Also don't forget to add a table with all "special" partition names and their usage. Waiting for the follow-up
Not sure what special partition names you're referring to - there was actually no special names for coreboot/FMAP.
If you are talking about the names to add PRESERVE in the follow up CL, that is very Chrome OS specific that I'm not sure if we will want to document it there (since if not using Chrome OS, default Coreboot images won't have those partitions).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2d99f570e6faff6ed3a4344d6af7526a4515fae
Gerrit-Change-Number: 31706
Gerrit-PatchSet: 5
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Mar 2019 16:14:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment