Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44772 )
Change subject: mb/prodrive/hermes/hda_verb: Fix some issues ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44772/4/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/4/src/mainboard/prodrive/herm... PS4, Line 29: MIC_IN,
Port A was a combination of rear mic in/ front header line out. […]
Done
https://review.coreboot.org/c/coreboot/+/44772/4/src/mainboard/prodrive/herm... PS4, Line 30: COMBINATION,
This should be other analog
Done
https://review.coreboot.org/c/coreboot/+/44772/4/src/mainboard/prodrive/herm... PS4, Line 72: /* Port F: Mic2, Audio Header #2 */
This implies that there are 2 audio headers. […]
Done