HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45372 )
Change subject: ec/kontron/kempld: Reflow long lines
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45372/8/src/ec/kontron/kempld/kempl...
File src/ec/kontron/kempld/kempld.c:
https://review.coreboot.org/c/coreboot/+/45372/8/src/ec/kontron/kempld/kempl...
PS8, Line 52: kempld_write8(reg, (val & ~(KEMPLD_UART_IO_MASK | KEMPLD_UART_IRQ_MASK))
: | io << KEMPLD_UART_IO_SHIFT
: | irq << KEMPLD_UART_IRQ_SHIFT)
looks better.
I think we need a rule...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5ad0715b742427dffa6c0c507269d904fe19bcb
Gerrit-Change-Number: 45372
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 11 Oct 2020 11:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment