Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39612 )
Change subject: sc7180: clock: Add display external clock in coreboot ......................................................................
Patch Set 29:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39612/22/src/soc/qualcomm/sc7180/cl... File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/39612/22/src/soc/qualcomm/sc7180/cl... PS22, Line 214: ;
Sorry, I don't understand (or agree with) this. […]
Ack
https://review.coreboot.org/c/coreboot/+/39612/15/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/39612/15/src/soc/qualcomm/sc7180/in... PS15, Line 34: #define mdss_reg_ptr(type, mem, base) \
Macros should be uppercase.
Ack
https://review.coreboot.org/c/coreboot/+/39612/15/src/soc/qualcomm/sc7180/in... PS15, Line 35: ((offsetof(type, mem)) + base)
Implementation updated as per latest comments from Julius.
Done