Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32718 )
Change subject: mainboard: remove "recovery" gpio, selectively add "presence" gpio. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32718/1/src/mainboard/google/storm/chromeos.... File src/mainboard/google/storm/chromeos.c:
https://review.coreboot.org/#/c/32718/1/src/mainboard/google/storm/chromeos.... PS1, Line 42: DEV_SW
Why did this change to DEV_SW?
The change to DEV_SW was requested by Julius here:
https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
quoting here:
"Actually, I think this is a mistake I made in https://review.coreboot.org/18980 -- I didn't notice that depthcharge was looking for that "developer" GPIO in board.c for this board. Looks like the original intent was that physical presence is asserted with DEV_SW here, so we should probably pass that as "presence". (Nobody will every build this from ToT anymore so it's kinda moot, but might as well try to do the right thing...)"