26 Nov
2019
26 Nov
'19
10:11 p.m.
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35503 )
Change subject: sc7180: Add USB support ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35503/15/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/35503/15/src/soc/qualcomm/sc7180/in... PS15, Line 95: -
nit: please be consistent in whether you have spaces around the minus or not, at least within the sa […]
This change (clock.h) now moved to the clock driver commit. All array ranges consistent with spaces added.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35503
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0651fc28dc227efbeb23eeefe9b96a3b940ae995
Gerrit-Change-Number: 35503
Gerrit-PatchSet: 18
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Sandeep Maheswaram sanm@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 22:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment