[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Add display driver

[yongqiang niu (Code Review)]

yongqiang niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )

Change subject: mediatek/mt8183: Add display driver
......................................................................

Patch Set 14:
> Patch Set 14:
> > there are 18 functions in 8183 ddp.c, but only 1(color_start) of them is same with 8173, the duplicate rate is 5.5%
>
> We should look at functions that can be integrated. For example,
>
> disp_config_main_path_mutex has only difference in clock source line
>
> ovl_set_roi can be merged by 8183's version (and for 8173 we simply call with idx=0)
>
> ovl_layer_enable also only needs an additional index arg
>
> rdma_start also only needs an additional index arg
>
> rdma_config is almost the same - probably also only need the index arg
>
> And there can be more to be refactored.

if refactor these function as you mentioned, is there anyone could test the refactor patch on 8173 platform?