[coreboot-gerrit] [XL] Change in coreboot[master]: util: cbfstool: Add '%<alignment>' in flashmap descriptor

[Hung-Te Lin (Code Review)]

Attention is currently required from: Aaron Durbin, Furquan Shaikh, Julius Werner.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262?usp=email )

Change subject: util: cbfstool: Add '%<alignment>' in flashmap descriptor
......................................................................

Patch Set 13:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/37262/comment/e1f76d0e_e1ef4dd6 :
PS11, Line 17: don't need to
             : be aligned, add a '%' after section
> I would prefer a single character because I think a big UNALIGNED tag makes this a lot more opticall […]

Done - choosing '%n' in the end. (%0 implies unaligned)

File Documentation/lib/flashmap.md:

https://review.coreboot.org/c/coreboot/+/37262/comment/50e02a74_5c9696dc :
PS11, Line 114: must be aligned to erase block (e.g., 4k).
> Yeah, I don't think you can tie this to existing Kconfigs in any way. […]

Done

File util/cbfstool/fmd_parser.y:

https://review.coreboot.org/c/coreboot/+/37262/comment/a207019e_dd817562 :
PS11, Line 121: 0x1000
> We're hard coding 4KiB?

Yes, as described in the commit message.