Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: superio/common: Add ssdtgen for generic SuperIOs
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic...
File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic...
PS19, Line 29: res->flags |= IORESOURCE_STORED;
it marks the SuperIO config port as used and then prints it in report_resource_stored(). […]
ok
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic...
PS19, Line 167: * coreboot's generic allocator doesn't expect them behind PnP devices.
The reason why it is an pnp device is simple: it allows to store the config port in devicetree and i […]
ok, that makes sense
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2716ae0580d68e5d4fcc484cb1648a2cdc1f4ca0
Gerrit-Change-Number: 33033
Gerrit-PatchSet: 19
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Aug 2019 07:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment