Attention is currently required from: Wisley Chen. Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/58563
to review the following change.
Change subject: mb/google/dedede/var/lantis: Generate new SPD ID for new memory parts Add new memory parts in memory_parts_used.txt and generate SPD id for these parts: The new memory pars: H54G46CYRBX267 K4U6E3S4AB-MGCL ......................................................................
mb/google/dedede/var/lantis: Generate new SPD ID for new memory parts Add new memory parts in memory_parts_used.txt and generate SPD id for these parts: The new memory pars: H54G46CYRBX267 K4U6E3S4AB-MGCL
BUG=None TEST=run part_id_gen to generate SPD id
Change-Id: I78ec575d354a5ae7c014a6050364d0a5214e4e92 Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc M src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt 3 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/58563/1
diff --git a/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc b/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc index 5c0d156..a6b19e1 100644 --- a/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/lantis/memory src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt +# ./util/spd_tools/lp4x/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/lantis/memory/ src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt
SPD_SOURCES = -SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D1NP-046 WT:B +SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D1NP-046 WT:B, H54G46CYRBX267, K4U6E3S4AB-MGCL diff --git a/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt index 8f0a779..2468965 100644 --- a/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt @@ -1,10 +1,12 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# util/spd_tools/bin/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/lantis/memory src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt +# ./util/spd_tools/lp4x/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/lantis/memory/ src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt
DRAM Part Name ID to assign MT53E512M32D2NP-046 WT:E 0 (0000) H9HCNNNBKMMLXR-NEE 0 (0000) K4U6E3S4AA-MGCR 0 (0000) MT53E512M32D1NP-046 WT:B 0 (0000) +H54G46CYRBX267 0 (0000) +K4U6E3S4AB-MGCL 0 (0000) diff --git a/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt index 09ed381..f195c25 100644 --- a/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt @@ -2,3 +2,5 @@ H9HCNNNBKMMLXR-NEE K4U6E3S4AA-MGCR MT53E512M32D1NP-046 WT:B +H54G46CYRBX267 +K4U6E3S4AB-MGCL