[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell/chip.c: Configure LPSS devices in correct mode

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29284 )

Change subject: soc/intel/braswell/chip.c: Configure LPSS devices in correct mode
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/29284/11//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29284/11//COMMIT_MSG@27 
PS11, Line 27: devices/connections are available.
> Linux is reporting 'i2c /dev entries driver' but I could not check if the controllers are working. […]

As discussed, there are probably better ways to handle this.
Maybe remove the PcdEnable* settings from `chip.h` and use the
`pci device ... on/off` setting instead. Then, nobody could
accidentally put individual devices into ACPI mode.