build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: superio/common: Add ssdtgen for generic SuperIOs ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33033/18/src/superio/common/generic... File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/33033/18/src/superio/common/generic... PS18, Line 45: const char *scope = acpi_device_scope(dev); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/33033/18/src/superio/common/generic... PS18, Line 45: const char *scope = acpi_device_scope(dev); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/33033/18/src/superio/common/generic... PS18, Line 133: acpigen_write_indexfield("INDX", "DATA", i, ARRAY_SIZE(i), FIELD_BYTEACC | FIELD_NOLOCK | line over 96 characters