Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31458 )
Change subject: drivers/intel/gma: Export Read_EDID() to C ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31458/3/src/drivers/intel/gma/gma.a... File src/drivers/intel/gma/gma.ads:
https://review.coreboot.org/c/coreboot/+/31458/3/src/drivers/intel/gma/gma.a... PS3, Line 7: read_edid
Not resolved yet?
Sorry, the whole series is stalled by the zero review progress on the other side (libgfxinit).
Now that I'm looking at it:
I break with Ada conventions when I write things in lower case, I know. The idea was to try it out here in coreboot how it looks like when we align the style more with our C. Doesn't look very well when it's mixed with existing interfaces in Camel_Case, but when you write some more lines, it starts to work out, imho: Easier to type and to read.
As I'm still the only one writing Ada code in the coreboot repo :'( I didn't think about discussing conventions yet.