[coreboot-gerrit] Change in ...coreboot[master]: include: Implement abs()

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32501 )

Change subject: include: Implement abs()
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32501/3/src/include/stdlib.h 
File src/include/stdlib.h:

https://review.coreboot.org/#/c/32501/3/src/include/stdlib.h@14 
PS3, Line 14: static inline int abs(int i)
            : {
            : 	return i < 0 ? -i : i;
            : }
> Would it not make more sense to implement it as a macro such that you can use different integer type […]

it's a function defined in C89. It might cause issues if it does not return an int.