Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33739 )
Change subject: soc/intel/icelake: Update FSP UPDs if IGD is disable in devicetree
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33739/12/src/soc/intel/icelake/fsp_...
File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/33739/12/src/soc/intel/icelake/fsp_...
PS12, Line 87: * the FSP does not initialize this device
This is written as a conclusion, not a statement, please fix.
https://review.coreboot.org/c/coreboot/+/33739/12/src/soc/intel/icelake/fsp_...
PS12, Line 91: else {
Please use braces in accordance with our coding style.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34a02bff112f922cabd48c23bc76370892ec62d9
Gerrit-Change-Number: 33739
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 12 Jul 2019 15:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment