Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33739 )
Change subject: soc/intel/icelake: Add option to enable display over PCI external GFX ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33739/9/src/soc/intel/icelake/Kconf... File src/soc/intel/icelake/Kconfig:
PS9:
I have explained below, please check, VGA_ROM_RUN is just to check below code if need to look for Op […]
Thank you for the explanation. In my opinion VGA_ROM_RUN should imply `ALWAYS_RUN_OPROM`. I do not see how the current logic is helpful. Could you rather fix that up?
https://review.coreboot.org/c/coreboot/+/33739/9/src/soc/intel/icelake/Kconf... PS9, Line 216: select FRAMEBUFFER_SET_VESA_MODE
CONFIG_VGA_ROM_RUN is just to check if cb will look for OpRom or not. […]
Sorry, for being unclear. I meant `FRAMEBUFFER_SET_VESA_MODE` specifically.
https://review.coreboot.org/c/coreboot/+/33739/9/src/soc/intel/icelake/romst... File src/soc/intel/icelake/romstage/fsp_params.c:
PS9:
i didn't get u
Can the changes to this file be put into a separate commit, so that the discussion about the Kconfig options do not hold up this functional change (which does not use the Kconfig symbol)?