Attention is currently required from: Nico Huber, Subrata Banik.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48244 )
Change subject: soc/intel/cannonlake/Kconfig: Allow building for x86_64
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
@Patrick: Have you tested this with FSP APIs ?
Yes, this is a regular build with FSP-M and FSP-S involved and FSP MPInit disabled. It automatically uses the protected mode wrapper to run FSP binaries in x86_32 mode. It'll likely not work with FSP MPinit as there are no wrappers around the PPI yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48244
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2919766acc2e11d81c279c23380a9e6fd50f0bb
Gerrit-Change-Number: 48244
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 25 Nov 2021 08:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment