Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_FAFT_KEY_OVERIDE setting ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36518/7/src/soc/qualcomm/common/qcl... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/7/src/soc/qualcomm/common/qcl... PS7, Line 162: if (!(gbb_is_flag_set(VB2_GBB_FLAG_FAFT_KEY_OVERIDE))) {
This is how flag is spelled in vboot source code.
It's fine, just ignore the warning.
Also, can we just write this with && (instead of nested if)?
https://review.coreboot.org/c/coreboot/+/36518/7/src/soc/qualcomm/sc7180/Mak... File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36518/7/src/soc/qualcomm/sc7180/Mak... PS7, Line 43: romstage-$(CONFIG_QC_SDI_ENABLE) += ../../../security/vboot/gbb.c Please just change security/vboot/Makefile.inc to always do this (in a separate patch).
...actually, there are more issues with that... hmm... let me just quickly do this and then this becomes moot: CB:37261