2 comments:
File src/soc/qualcomm/common/qclib.c:
Patch Set #7, Line 162: if (!(gbb_is_flag_set(VB2_GBB_FLAG_FAFT_KEY_OVERIDE))) {
This is how flag is spelled in vboot source code.
It's fine, just ignore the warning.
Also, can we just write this with && (instead of nested if)?
File src/soc/qualcomm/sc7180/Makefile.inc:
Patch Set #7, Line 43: romstage-$(CONFIG_QC_SDI_ENABLE) += ../../../security/vboot/gbb.c
Please just change security/vboot/Makefile.inc to always do this (in a separate patch).
...actually, there are more issues with that... hmm... let me just quickly do this and then this becomes moot: CB:37261
To view, visit change 36518. To unsubscribe, or for help writing mail filters, visit settings.