David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37236 )
Change subject: mb/google/hatch/var/kindred: Add ELAN touchscreen support
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37236/2/src/mainboard/google/hatch/...
PS2, Line 159: 130
Where did this number come from? I believe this is connected to the Report_En signal, and requires […]
Thanks for reminder, it come from dratini. https://review.coreboot.org/c/coreboot/+/36125/3/src/mainboard/google/hatch/...
I have updated stop delay to 300ms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b003685cd7ee68738bcd4298b63a44d6e6118e4
Gerrit-Change-Number: 37236
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 02:34:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment