Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )
Change subject: soc/intel/cannonlake: Dump ME f/w version and status information.
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/me.h:
https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/include/soc...
PS8, Line 4: Inc.
LLC
https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/me.c
File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/#/c/32527/8/src/soc/intel/cannonlake/me.c@235
PS8, Line 235: print_me_version
And the reason why this cannot be called from dump_me_status() is probably because its too late and ME does not respond to GET_FW_VERSION command? At least that was the observation on SKL/KBL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibeb3a2a85cd84c9baa45f90f20a3dcf69f7d5646
Gerrit-Change-Number: 32527
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 20 May 2019 18:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment