Attention is currently required from: Angel Pons, Nicholas Chin.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68264 )
Change subject: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/usb/gadget.c:
https://review.coreboot.org/c/coreboot/+/68264/comment/b4941768_4ed3097b
PS4, Line 215: } __packed;
I guess what matters here is that those fields are in that order in a contiguous 7 byte area, and th […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd4ad17b7369948003fff7e825b46fe852bc7eb9
Gerrit-Change-Number: 68264
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 11 Nov 2022 13:14:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment