Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 21:
(9 comments)
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-aarch64.md:
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 1: # QEMU AArch64 emulator must be referenced from index.md
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 7: 2. Add a DTS to a FIT image by the util (I'm developing it now.) How to get the DTS?
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 12: TODO: Write the command how to build a FIT image. already described here: https://doc.coreboot.org/lib/payloads/fit.html You could reference it here, but please don't duplicate.
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 15: TODO: Make the util and write the command how to use the util Already done automatically if you select LinuxBoot payload.
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 17: ### 3. Make coreboot.rom with an emply payload seems to be general workflow how to select a board, not worth of documenting it
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 30: ### 4. Add the payload to coreboot.rom by util/cbfstool wrong. Use Linux/LinuxBoot payload instead
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 34: ``` ```bash
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 38: - The default CPU in QEMU for AArch64 is a cortex-a15 which is 32-bit ARM CPU. You need to specify 64-bit ARM CPU via `-cpu cortex-a53`. move to top as it's important when running qemu for this board
https://review.coreboot.org/c/coreboot/+/33387/21/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/33387/21/src/mainboard/emulation/qe... PS21, Line 26: BOOTBLOCK(0x60010000, 64K) that assumes 512+32MiB of DRAM specified with -m. That needs to be documented.