Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36339 )
Change subject: soc/intel/common: add common function to set LT_LOCK_MEMORY
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36339/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/36339/5/src/soc/intel/common/block/...
PS5, Line 326: msr_set_bit(MSR_LT_CONTROL, LT_CONTROL_LOCK_BIT);
does it crash if lock bit is set twice?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36339
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ca719a9c81dca40181816d75f4dcadab257c0b3
Gerrit-Change-Number: 36339
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Oct 2019 10:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment