[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel: Add node_num to dimm_info struct + adjust dimm_info_fill

[David Milosevic (Code Review)]

Attention is currently required from: [e-mail], Angel Pons, Arthur Heymans, TangYiwei, Andrey Petrov, Tarun Tuli, Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Tim Wawrzynczak, Lean Sheng Tan, Werner Zeh, David Milosevic, Tim Chu.

Hello build bot (Jenkins), Jonathan Zhang, [e-mail], Angel Pons, Arthur Heymans, TangYiwei, Andrey Petrov, Tarun Tuli, Anjaneya "Reddy" Chagam, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Tim Wawrzynczak, Lean Sheng Tan, Werner Zeh, Tim Chu, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/68525

to look at the new patch set (#5).

Change subject: soc/intel: Add node_num to dimm_info struct + adjust dimm_info_fill
......................................................................

soc/intel: Add node_num to dimm_info struct + adjust dimm_info_fill

The dimm_info structure (defined in src/include/memory_info.h)
currently does not hold information about the DIMM's
node/controller ID.

This patch extends the dimm_info structure by adding a new field for
the node ID, called node_num. Also, adapt the dimm_info_fill()
function accordingly to populate the newly-added field.

Background: These changes are necessary for the Atlas mainboard, where
we are currently experiencing issues with the DIMMs device/bank
locator. Our 2 DIMMs share the same CHANNEL and DIMM ID but have a
distinct NODE ID. By looking at the smbios table we see
Channel-0-DIMM-0 for both DIMMs. Thus, we need their NODE IDs in order
to distinguish them.

This patch was tested by building and booting for the Alderlake-P
RVP board, which has the same DIMM slot configuration as the
Prodrive Atlas mainboard.

Signed-off-by: David Milosevic <[e-mail]>
Change-Id: I6ffa5bdff0ba0e3c4a4a51f2419291fd1278cd68
---
M src/include/memory_info.h
M src/soc/intel/alderlake/romstage/romstage.c
M src/soc/intel/apollolake/meminit_util_apl.c
M src/soc/intel/apollolake/meminit_util_glk.c
M src/soc/intel/cannonlake/romstage/romstage.c
M src/soc/intel/common/smbios.c
M src/soc/intel/common/smbios.h
M src/soc/intel/elkhartlake/romstage/romstage.c
M src/soc/intel/icelake/romstage/romstage.c
M src/soc/intel/jasperlake/romstage/romstage.c
M src/soc/intel/meteorlake/romstage/romstage.c
M src/soc/intel/skylake/romstage/romstage.c
M src/soc/intel/tigerlake/romstage/romstage.c
M src/soc/intel/xeon_sp/cpx/romstage.c
14 files changed, 65 insertions(+), 12 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/68525/5
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68525
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ffa5bdff0ba0e3c4a4a51f2419291fd1278cd68
Gerrit-Change-Number: 68525
Gerrit-PatchSet: 5
Gerrit-Owner: David Milosevic <[e-mail]>
Gerrit-Reviewer: Andrey Petrov <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Christian Walter <[e-mail]>
Gerrit-Reviewer: Johnny Lin <[e-mail]>
Gerrit-Reviewer: Jonathan Zhang <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tarun Tuli <[e-mail]>
Gerrit-Reviewer: Tim Chu <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: Werner Zeh <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: [e-mail]
Gerrit-Attention: [e-mail]
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Attention: TangYiwei
Gerrit-Attention: Andrey Petrov <[e-mail]>
Gerrit-Attention: Tarun Tuli <[e-mail]>
Gerrit-Attention: Anjaneya "Reddy" Chagam <[e-mail]>
Gerrit-Attention: Johnny Lin <[e-mail]>
Gerrit-Attention: Christian Walter <[e-mail]>
Gerrit-Attention: Tim Wawrzynczak <[e-mail]>
Gerrit-Attention: Lean Sheng Tan <[e-mail]>
Gerrit-Attention: Werner Zeh <[e-mail]>
Gerrit-Attention: David Milosevic <[e-mail]>
Gerrit-Attention: Tim Chu <[e-mail]>
Gerrit-MessageType: newpatchset