Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: Support more DRAM frequency bootup
......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34332/18//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34332/18//COMMIT_MSG@11
PS18, Line 11:
For such a big diffstat you should elaborate more on the implementation.
https://review.coreboot.org/c/coreboot/+/34332/18/src/soc/mediatek/mt8183/dr...
File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34332/18/src/soc/mediatek/mt8183/dr...
PS18, Line 159: (0x7 << 0) | (0x3 << 18), (0x0 << 0) | (0x1 << 18));
Format changes should be in separate commits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1378ca43fb333c445ca77e7dc0844cdf65f2207
Gerrit-Change-Number: 34332
Gerrit-PatchSet: 18
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Sj Huang
sj.huang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Aug 2019 12:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment