Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33842 )
Change subject: src/superio/nuvoton: Add support for NCT5539D
......................................................................
Patch Set 28: Code-Review+2
(2 comments)
all issues are addressed and buildbot is happy with the board using this SIO
https://review.coreboot.org/c/coreboot/+/33842/10/src/superio/nuvoton/common...
File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/33842/10/src/superio/nuvoton/common...
PS10, Line 78: 0x40
no, this is simply not true. […]
Done
https://review.coreboot.org/c/coreboot/+/33842/10/util/superiotool/nuvoton.c
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/33842/10/util/superiotool/nuvoton.c...
PS10, Line 597: {0x06, "Consumer IR",
Will do.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e979bde53ce3dac1a4f74e7e51a3c6a0149051c
Gerrit-Change-Number: 33842
Gerrit-PatchSet: 28
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Jul 2019 17:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Pavel Sayekat
Gerrit-MessageType: comment