[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/alderlake: Select FSP MULTIPHASE SI INIT RETURN BROKEN config

[Subrata Banik (Code Review)]

Attention is currently required from: Derek Huang, Kapil Porwal.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74785 )

Change subject: soc/intel/alderlake: Select FSP_MULTIPHASE_SI_INIT_RETURN_BROKEN config
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS2:
> nice work! Can we have decode for the reset type from FSP instead 40000003 something like this.

are u asking how to decode 0x40000003 inside FSP.

It's part of the FSP inegration guide and per soc select the applicable reset type (for example: MTL does 	select FSP_STATUS_GLOBAL_RESET_REQUIRED_3)

config FSP_STATUS_GLOBAL_RESET
    hex
    depends on SOC_INTEL_COMMON_FSP_RESET
    default 0x40000003 if FSP_STATUS_GLOBAL_RESET_REQUIRED_3
    default 0x40000004 if FSP_STATUS_GLOBAL_RESET_REQUIRED_4
    default 0x40000005 if FSP_STATUS_GLOBAL_RESET_REQUIRED_5
    default 0x40000006 if FSP_STATUS_GLOBAL_RESET_REQUIRED_6
    default 0x40000007 if FSP_STATUS_GLOBAL_RESET_REQUIRED_7
    default 0x40000008 if FSP_STATUS_GLOBAL_RESET_REQUIRED_8
    default 0xffffffff
    help
      If global reset is supported by SoC then select the correct status value for global
      reset type from SoC Kconfig based on available Kconfig options
      FSP_STATUS_GLOBAL_RESET_REQUIRED_X. Default is unsupported.