[coreboot-gerrit] [M] Change in coreboot[main]: sb/intel/common: Add GPIO serial blink console support

[Jérémy Compostella (Code Review)]

Attention is currently required from: Intel coreboot Reviewers, Keith Hui.

Jérémy Compostella has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/86390?usp=email )

Change subject: sb/intel/common: Add GPIO serial blink console support
......................................................................

Patch Set 1:

(3 comments)

File src/console/Kconfig:

https://review.coreboot.org/c/coreboot/+/86390/comment/fcec6aa0_f65a45e1?usp... :
PS1, Line 399: 	int "GPIO output pin (0-31)"
Could use a `range` instead (https://doc.coreboot.org/getting_started/kconfig.html).

File src/southbridge/intel/common/gpio.c:

https://review.coreboot.org/c/coreboot/+/86390/comment/f33da15f_c3a0f067?usp... :
PS1, Line 47: 	/* Temporarily set the GPIO to input, enable serial blink, then change it to output.
https://doc.coreboot.org/contributing/coding_style.html#commenting

https://review.coreboot.org/c/coreboot/+/86390/comment/44b25b53_e532d2d4?usp... :
PS1, Line 195: CONSOLE_INTEL_GPSB)
Couldn't in its own C file instead ?