You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32097 )
Change subject: WIP: mediaek/mt8183: add panel driver for kukui p2
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32097/7/src/mainboard/google/kukui/mainboard...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/32097/7/src/mainboard/google/kukui/mainboard...
PS7, Line 16: #include <boardid.h>
It would be better to have changes in soc/mediatek/mt8183/ and changes in mainboard/google/kukui/ in separate CLs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32097
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I878c9e0454acdbc0cd2cd310b8519efb845bb6ee
Gerrit-Change-Number: 32097
Gerrit-PatchSet: 7
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-CC: Nicolas Boichat
drinkcat@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Apr 2019 22:23:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment