Attention is currently required from: Paul Menzel.
Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: arch/x86/smbios: Avoid buffer overflows ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74128/comment/69acd619_f6230b79 PS1, Line 7: src/arc/x86/smbios.c: Fix coverity issues
The prefix does not need to (and should not) be the path. Please use: *arch/x86/smbios*.
Ack
https://review.coreboot.org/c/coreboot/+/74128/comment/86081c48_33927efc PS1, Line 7: Fix coverity issues
Please make the commit message summary/title about the action/code change. […]
Ack
https://review.coreboot.org/c/coreboot/+/74128/comment/9bd059e1_d2e2ab45 PS1, Line 12: Closes #431
Please look through `git log --grep Found-by` how to reference Coverity issues.
Ack
Patchset:
PS3: I've implemented the changes suggested by you. Please have a look. Also, there are some other CIDs which I would love to get some suggestions for. Could you please have a look at this:
https://docs.google.com/spreadsheets/d/15o8avjO7zCQMKGbjcqdUk-OB1Ax--sEt7flz...
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74128/comment/7d6a18c8_df86932b PS1, Line 22: : #define update_max(len, max_len, stmt) \ : do { \ : int tmp = stmt; \ : max_len = MAX(max_len, tmp); \ : len += tmp; \
Separate unrelated change?
Ack