Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41155 )
Change subject: soc/intel/common/block/systemagent: Use TOUUD as base for MMIO above 4G
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41155/3/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/41155/3/src/soc/intel/tigerlake/inc...
PS3, Line 79: #define ABOVE_4GB_MEM_BASE_SIZE (256ULL * GiB)
TGL supports 512GiB of address space (39 bits). So size should really be 512GiB - TOUUD.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41155
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbbfbdad867735a43cf57c256bf206a3f040f383
Gerrit-Change-Number: 41155
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 May 2020 17:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment