Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48599 )
Change subject: em100: Add SPI trace console
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/em100/+/48599/2/trace.c
File trace.c:
https://review.coreboot.org/c/em100/+/48599/2/trace.c@345
PS2, Line 345: 4
Shouldn't this be 0?
--
To view, visit
https://review.coreboot.org/c/em100/+/48599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I78162585bcd73a3bb3a8aa590f43a96092946109
Gerrit-Change-Number: 48599
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Dec 2020 00:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment