Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39004 )
Change subject: drivers: Replace a few set_vbe_mode_info_valid ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39004/7/src/soc/nvidia/tegra210/dc.... File src/soc/nvidia/tegra210/dc.c:
https://review.coreboot.org/c/coreboot/+/39004/7/src/soc/nvidia/tegra210/dc.... PS7, Line 231: //FIXME: Why not config->framebuffer_base?
Does it make sense to allocate a framebuffer information at all if the payload has it's own code for […]
Well, we definitely need all the other information stuff (height, width, bpp, etc.), because coreboot still configures the display controller and is in charge of figuring all that out. All the payload does is allocate the actual memory for the framebuffer and then do the one hardware access needed to tell that base address to the display controller. (I think there's also the option of coreboot setting config->framebuffer_base and then libpayload will try to reserve memory exactly there if possible. I don't think any of the Chrome OS platforms use it that way, but libpayload supports both.)